Skip to content

feat: add discover-driven filters for yarn lint, dig, git cherry-pick, git remote#1509

Open
xronocode wants to merge 1 commit into
rtk-ai:developfrom
xronocode:feat/discover-filters
Open

feat: add discover-driven filters for yarn lint, dig, git cherry-pick, git remote#1509
xronocode wants to merge 1 commit into
rtk-ai:developfrom
xronocode:feat/discover-filters

Conversation

@xronocode
Copy link
Copy Markdown

@xronocode xronocode commented Apr 25, 2026

Summary

Adds discover-driven coverage for commands that are still absent from current origin/develop:

TOML filters (2 new):

  • yarn-lint.toml — strips progress noise and blank lines from yarn lint output
  • dig.toml — keeps DNS answer sections and query metadata while stripping decorative headers

Rust git handlers (2 new):

  • git cherry-pick — compacts successful output while preserving full conflict output
  • git remote — compacts listings, deduplicates -v output, and summarizes mutating actions

Discover updates:

  • Classifies yarn, dig, git cherry-pick, git remote, and existing ssh TOML coverage
  • Extends the git discover pattern to cover cherry-pick and remote
  • Adds registry tests for the new classifications
  • Updates built-in TOML filter counts from 59 to 61

Freshness check

Checked against current origin/develop after rebasing:

  • dig.toml is not present upstream
  • yarn-lint.toml is not present upstream
  • dedicated rtk git cherry-pick and rtk git remote handlers are not present upstream
  • ssh.toml already exists upstream; this PR only adds discover classification for it
  • upstream has cherry-pick status detection inside rtk git status, but not a git cherry-pick command handler

Testing

  • cargo test: 1822 passed, 0 failed, 6 ignored
  • cargo test discover::registry::tests: 276 passed
  • cargo test core::toml_filter::tests: 49 passed
  • cargo fmt -- --check: passed

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 25, 2026

CLA assistant check
All committers have signed the CLA.

@pszymkowiak pszymkowiak added effort-medium 1-2 jours, quelques fichiers enhancement New feature or request labels Apr 25, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

Type feature
🟢 Risk low

Summary

Adds discover-driven filters for yarn lint, dig, git cherry-pick, and git remote commands. Includes two new TOML filters (yarn-lint, dig), two new Rust-based git subcommand handlers (cherry-pick, remote), new discover classification rules for yarn/dig/ssh, and corresponding tests.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Analyzed automatically by wshm · This is an automated analysis, not a human review.

@xronocode xronocode changed the base branch from master to develop April 25, 2026 02:46
@xronocode xronocode closed this Apr 25, 2026
@xronocode xronocode deleted the feat/discover-filters branch April 25, 2026 02:47
@xronocode xronocode restored the feat/discover-filters branch April 25, 2026 02:52
@xronocode xronocode reopened this Apr 25, 2026
@xronocode xronocode force-pushed the feat/discover-filters branch from 9cfc337 to 68c0af7 Compare April 25, 2026 02:56
@xronocode xronocode force-pushed the feat/discover-filters branch from 68c0af7 to 39ce3db Compare May 8, 2026 12:50
…, git remote

Add discover-driven coverage for commands that are still absent from origin/develop.

New TOML filters:

- yarn-lint.toml: strip progress noise and blank lines from yarn lint output

- dig.toml: keep DNS answer sections and query metadata while stripping decorative headers

New git handlers:

- git cherry-pick: compact successful output while preserving full conflict output

- git remote: compact listings, deduplicate -v output, and summarize mutating actions

Discover updates:

- classify yarn, dig, git cherry-pick, git remote, and existing ssh TOML coverage

- update registry tests and built-in TOML filter counts
@xronocode xronocode force-pushed the feat/discover-filters branch from 39ce3db to e722031 Compare May 8, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort-medium 1-2 jours, quelques fichiers enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants